Wrong calculation due to incorrect expression parsing with subtraction

[dslad]

This works as expected (with a space between '3' and '-')

2020/01/01 Works
    Assets:Cash    (£10*(3 -1))
    Equity

But this transaction is silently ignored, I guess because the expression incorrectly evaluates to zero

2020/01/01 Doesn't work
    Assets:Cash    (£10*(3-1))
    Equity

[tbm]

I guess because the expression incorrectly evaluates to zero

I don't know why, but you are absolutely right.

~/tmp/src/ledger/ledger -f  d reg
~/tmp/src/ledger/ledger -f  d reg --empty
2020-01-01 Doesn't work     Assets:Cash                                        0                        0
                            Equity                                             0                        0

Debug:

   25ms  [DEBUG] num prec = 385
   25ms  [DEBUG] den prec = 385
   25ms  [DEBUG] mpfr_print = 0 (precision 0, zeros_prec 0)
   25ms  [DEBUG] £0

[tbm]

--debug expr.calc says:

    1ms  [DEBUG] Calculating: (£10*(3-1))
    1ms  [DEBUG]   (£10 * 0) => ...
    1ms  [DEBUG] .  0 => ...
    1ms  [DEBUG] .  0 => 0
    2ms  [DEBUG] .  £10 => ...
    2ms  [DEBUG] .  £10 => £10
    2ms  [DEBUG]   (£10 * 0) => £0

[tbm]

Even simpler testcase:

2020/01/01 Doesn't work
    Assets:Cash    (3-1)
    Equity

debug:

    3ms  [DEBUG] Calculating: (3-1)
    3ms  [DEBUG]   0 => ...
    3ms  [DEBUG]   0 => 0

[tbm]

These all work fine:

2020/01/01 works
    Assets:Cash    (3*1)
    Equity

2020/01/01 works
    Assets:Cash    (3/1)
    Equity

2020/01/01 works
    Assets:Cash    (3+1)
    Equity

[tbm]

This was actually reported before, see #1809

[enderw88]

none of those have a commodity assigned. Does subtraction work if it does have a commodity assigned?

On Mon, Feb 8, 2021 at 02:22 Martin Michlmayr ***@***.***> wrote: These all work fine: 2020/01/01 works Assets:Cash (3*1) Equity 2020/01/01 works Assets:Cash (3/1) Equity 2020/01/01 works Assets:Cash (3+1) Equity — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2001 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGWWLCGBZBBXAL32J22ML3S56UO3ANCNFSM4XIRMLSQ> .

-- Craig, Corona De Tucson, AZ [image: missile_flyout] enderw88.wordpress.com

[tbm]

none of those have a commodity assigned. Does subtraction work if it does
have a commodity assigned?

yes, but imho that's not the point since a) value expressions support math, b) the original example had a commodity somewhere in the expression, and c) ledger doesn't require commodities.

[enderw88]

Negative signs?

…

On Mon, Feb 8, 2021 at 6:25 AM dslad ***@***.***> wrote: The problem seems to be in the *parse_quantity* function in amount.cc <https://github.com/ledger/ledger/blob/master/src/amount.cc>. Compiling with the offending "*|| c == '-'*" removed seems to function properly on the trivial examples. I can't think why hyphens should be allowed in quantities (unlike of course . and , ) ... but there may be a reason? namespace { void parse_quantity(std::istream& in, string& value) { char buf[256]; char c = peek_next_nonws(in); READ_INTO(in, buf, 255, c, std::isdigit(c) || c == '-' || c == '.' || c == ','); string::size_type len = std::strlen(buf); while (len > 0 && ! std::isdigit(buf[len - 1])) { buf[--len] = '\0'; in.unget(); } value = buf; } } — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2001 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGWWLDDQHXX46CVA5GCJELS57Q5VANCNFSM4XIRMLSQ> .

-- Craig, Corona De Tucson, AZ [image: missile_flyout] enderw88.wordpress.com

[dslad]

:) Seems to still recognise minus sign at the beginning of a quantity - it's ones in the middle that were causing problems.

[tbm]

I think this can be closed since PR #2027 got merged. Right?

[tbm]

Fixed in commit 4ba80c3