Shell-escaped the project path that we use for xcodebuild and lipo. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonino-u
changed the title
|
Please Note: the failing build has nothing to do with my change... |
This was referenced Mar 24, 2020
|
I can confirm and reproduce same issue in our project, and can confirm this PR fixes it. |
|
I can also confirm that it's an issue with projects where the build scheme contains spaces. This PR fixes the problem, please consider merging @leavez |
|
This PR fixes the problem with spaces in build scheme. Please merge it @leavez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #88.
Shellwords is built into Ruby, see the doc for what it does here: https://ruby-doc.org/stdlib-2.0.0//libdoc/shellwords/rdoc/Shellwords.html
In short, a path string like
/hello world' becomes suitably escaped for shell use, and transformed into/hello\ world`..shellescapewas added to string variables passed to both xcodebuild and lipo, and now things work as expected when there are characters (like spaces) that need to be escaped in the file paths.