Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license warning with subspecs #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylefleming
Copy link

CocoaPods-binary removes the license attribute from the podspec attributes hash since it doesn't copy the license file over. However, the license attribute in only valid in the root spec of a podspec.

There is currently a bug where if you specify a dependency on a subspec of a pod, then cocoapods-binary removes the license attribute not from the root spec, but from the subspec, thus leaving the license attribute in the root spec intact. This produces the following warning:

[!] Unable to read the license file `LICENSE` for the spec `<PodName> (<PodVersion>)`

This PR fixes this bug by using the root spec when removing the license attribute.

@anton-plebanovich
Copy link

Faced with the same issue. It'd be awesome to merge this one.

@anton-plebanovich
Copy link

I was able to reproduce with pod 'Moya/Core', :binary => true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants