Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: integrated moodleoverflow into the global search #62

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

sevenseas-gists
Copy link

closes #23 Provides basic search function via integration into the global search api

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2020

Codecov Report

Merging #62 into master will increase coverage by 2.79%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
+ Coverage     18.08%   20.87%   +2.79%     
- Complexity      453      485      +32     
============================================
  Files            43       44       +1     
  Lines          3982     4125     +143     
============================================
+ Hits            720      861     +141     
- Misses         3262     3264       +2     
Impacted Files Coverage Δ Complexity Δ
classes/search/moodleoverflowposts.php 0.00% <0.00%> (ø) 30.00 <30.00> (?)
classes/privacy/provider.php 81.62% <0.00%> (-0.46%) 16.00% <0.00%> (ø%)
classes/privacy/data_export_helper.php 98.33% <0.00%> (+0.05%) 42.00% <0.00%> (+2.00%)
locallib.php 9.55% <0.00%> (+3.02%) 0.00% <0.00%> (ø%)
lib.php 7.49% <0.00%> (+4.91%) 0.00% <0.00%> (ø%)
classes/ratings.php 35.20% <0.00%> (+31.20%) 91.00% <0.00%> (ø%)
classes/event/rating_created.php 50.00% <0.00%> (+50.00%) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7640c4...7efdd7a. Read the comment docs.

Copy link
Member

@justusdieckmann justusdieckmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
$levels needs to be either [CONTEXT_MODULE] or removed (since base_mod already defines it that way). Otherwise, the posts will not be found by student searches.

@Laur0r
Copy link
Contributor

Laur0r commented Oct 1, 2020

Hey could you leave detailed instructions on how to test the search function?

@NinaHerrmann
Copy link
Contributor

@rtschu ?

@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #62 (7efdd7a) into master (a297dd5) will decrease coverage by 0.64%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
- Coverage     21.51%   20.87%   -0.65%     
- Complexity      455      485      +30     
============================================
  Files            43       44       +1     
  Lines          4001     4125     +124     
============================================
  Hits            861      861              
- Misses         3140     3264     +124     
Impacted Files Coverage Δ Complexity Δ
classes/search/moodleoverflowposts.php 0.00% <0.00%> (ø) 30.00 <30.00> (?)
lib.php 7.49% <0.00%> (+0.01%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a297dd5...b83c57c. Read the comment docs.

@NinaHerrmann
Copy link
Contributor

NinaHerrmann commented Dec 2, 2020

Hey Robin,
nice, you are working on it 🙂 could you please check the warning of the codechecker before we start to review the pull request? Some of them might be not so so important but most of them are best practices that you should have a look at 🙂 Thanks in advance!

@sevenseas-gists sevenseas-gists changed the title integrated moodleoverflow into the global search WIP: integrated moodleoverflow into the global search Dec 2, 2020
@sevenseas-gists
Copy link
Author

absolutely, I meant to change the title to WIP until travis is ok have added that now :)

@mojaedukacja
Copy link

Global search works good only with full words, but not with word fragments (nice to have).

Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search function
7 participants