Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitedwidth page size fixes #148. #149

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

lucaboesch
Copy link
Contributor

@lucaboesch lucaboesch commented Jun 10, 2023

It shoudn't affect Moodle ≤ 3.11.

Copy link
Contributor

@TamaroWalter TamaroWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All sites from Moodleoverflow have now a smaller width:
Before:
view.php:
image

discussion.php:
image

post.php:
image

index.php:
image

Now:
view.php:
image

discussion.php:
image

post.php:
image

index.php:
image

@lucaboesch
Copy link
Contributor Author

Yeah, that is what I intended, @TamaroWalter.
From the student's point of view almost all activities have this user interface.
The broad pages are the one with tables, mostly addressed at lecturers (like grades, question bank participants etc).

@NinaHerrmann
Copy link
Contributor

Thanks both of you for the work. Although I am still not sure whether I prefer the limitedwidth in general I highly appreciate, that you mentioned the inconsistency!
Thanks @lucaboesch for implementing and @TamaroWalter for reviewing and documenting!

@NinaHerrmann NinaHerrmann merged commit 035c660 into learnweb:master Jun 20, 2023
@lucaboesch lucaboesch deleted the editlimitedwidth branch January 23, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants