Update/moodle 402 #130
Merged
Update/moodle 402 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classes/ratings.php
Outdated
| @@ -247,56 +262,96 @@ public static function moodleoverflow_sort_answers_by_ratings($posts) { | |||
| $statusstarter = self::moodleoverflow_discussion_is_solved($discussionid, false); | |||
| $statusteacher = self::moodleoverflow_discussion_is_solved($discussionid, true); | |||
|
|
|||
| // The answer that is marked as correct by both is displayed first. | |||
| // The answers that are marked as correct by both are displayed first. | |||
| if ($statusteacher && $statusstarter) { | |||
There was a problem hiding this comment.
I know this is not caused by you but the sequence of ordering the posts is really unintuitive- and hardly readable code.
- Check for post both marked (outsource in function)
- Check for preferred order and outsource ordering in separate function like
if ($preferteacher) {
sort_by_teacher(array x, array y, ...);
sort_by_helpful(array x, array y, ...);
} else {
sort_by_helpful(array x, array y, ...);
sort_by_teacher(array x, array y, ...);
}
…odleoverflow into update/Moodle_402
TamaroWalter
commented
May 22, 2023
classes/ratings.php
Outdated
| // Sort the answer posts by ratings. | ||
| // Build groups of different types of answers (Solved and helpful, only solved/helpful, other). | ||
| // statusteacher == 1 means the post is marked as solved. | ||
| // statusstarter == 1 means the post is marked as helpful. |
classes/ratings.php
Outdated
|
|
||
| // Sort the answer posts by ratings. | ||
| // Build groups of different types of answers (Solved and helpful, only solved/helpful, other). | ||
| // statusteacher == 1 means the post is marked as solved. |
tests/ratings_test.php
Outdated
| $result = $this->postsorderequal($sortedposts, $rightorderposts); | ||
| $this->assertEquals(1, $result); | ||
|
|
||
| // Test without posts that are marked as both helpful and marked. |
There was a problem hiding this comment.
both helpful and solved...
version.php
Outdated
| @@ -28,8 +28,8 @@ | |||
| defined('MOODLE_INTERNAL') || die(); | |||
|
|
|||
| $plugin->component = 'mod_moodleoverflow'; | |||
| $plugin->version = 2023050801; | |||
| $plugin->release = 'v4.1-r1'; | |||
| $plugin->version = 2023050802; | |||
There was a problem hiding this comment.
set to today's date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.