codecleaning

classes/output/moodleoverflow_email.php

@@ -73,13 +73,13 @@ class moodleoverflow_email implements \renderable, \templatable {
     /**
      * Whether the user can reply to this post.
      *
-     * @var boolean $canreply
+     * @var bool $canreply
      */
     protected $canreply = false;
 
     /**
      * Whether to override forum display when displaying usernames.
-     * @var boolean $viewfullnames
+     * @var bool $viewfullnames
      */
     protected $viewfullnames = false;
 

classes/privacy/provider.php

@@ -50,7 +50,7 @@ class provider implements
      *
      * @return collection the updated collection of metadata items.
      */
-    public static function get_metadata(collection $collection) : collection {
+    public static function get_metadata(collection $collection): collection {
         $collection->add_database_table('moodleoverflow_discussions',
             [
                 'name' => 'privacy:metadata:moodleoverflow_discussions:name',
@@ -135,7 +135,7 @@ public static function get_metadata(collection $collection) : collection {
      *
      * @return contextlist $contextlist The list of contexts used in this plugin.
      */
-    public static function get_contexts_for_userid(int $userid) : contextlist {
+    public static function get_contexts_for_userid(int $userid): contextlist {
         // Fetch all Moodleoverflow discussions, moodleoverflow posts, ratings, tracking settings and subscriptions.
         $sql = "SELECT c.id
                 FROM {context} c

lang/en/moodleoverflow.php

@@ -29,11 +29,11 @@
 
 // Default strings.
 $string['modulename'] = 'Moodleoverflow';
-$string['modulenameplural'] = 'Moodleoverflows';
 $string['modulename_help'] = 'The Moodleoverflow module enables participants to use a question-answer forum structure. The forum display is non-chronological as the ordering depends on collaborative voting instead of on time.';
+$string['modulenameplural'] = 'Moodleoverflows';
+$string['moodleoverflow'] = 'Moodleoverflow';
 $string['moodleoverflowfieldset'] = 'Custom example fieldset';
 $string['moodleoverflowname'] = 'Moodleoverflow name';
-$string['moodleoverflow'] = 'Moodleoverflow';
 $string['pluginadministration'] = 'Moodleoverflow administration';
 $string['pluginname'] = 'Moodleoverflow';
 

tests/behat/behat_mod_moodleoverflow.php

@@ -247,12 +247,12 @@ public function should_not_exist_in_the_moodleoverflow_discussion_card($element,
     public function i_set_the_moodleoverflow_limitedanswertime_to_now($activity): void {
         global $DB;
 
-        if (!$activityRecord = $DB->get_record('moodleoverflow', ['name' => $activity])) {
+        if (!$activityrecord = $DB->get_record('moodleoverflow', ['name' => $activity])) {
             throw new Exception("Activity '$activity' not found");
         }
 
         // Update the specified field
-        $activityRecord->limitedanswer = time();
-        $DB->update_record('moodleoverflow', $activityRecord);
+        $activityrecord->limitedanswer = time();
+        $DB->update_record('moodleoverflow', $activityrecord);
     }
 }

tests/dailymail_test.php

@@ -39,7 +39,7 @@
  * @copyright 2023 Tamaro Walter
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class dailymail_test extends \advanced_testcase {
+final class dailymail_test extends \advanced_testcase {
 
     /** @var \stdClass collection of messages */
     private $sink;

tests/locallib_test.php

@@ -36,7 +36,7 @@
  * @copyright 2017 Kennet Winter <[email protected]>
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class locallib_test extends advanced_testcase {
+final class locallib_test extends advanced_testcase {
 
     public function setUp(): void {
         \mod_moodleoverflow\subscriptions::reset_moodleoverflow_cache();

tests/post_test.php

@@ -33,7 +33,7 @@
  * @copyright 2023 Tamaro Walter
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class post_test extends \advanced_testcase {
+final class post_test extends \advanced_testcase {
 
     /** @var \stdClass test course */
     private $course;

tests/privacy_provider_test.php

@@ -41,7 +41,7 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers \provider
  */
-class privacy_provider_test extends \core_privacy\tests\provider_testcase {
+final class privacy_provider_test extends \core_privacy\tests\provider_testcase {
     /**
      * @var \mod_moodleoverflow_generator Plugin generator
      */

tests/ratings_test.php

@@ -37,7 +37,7 @@
  * @copyright 2023 Tamaro Walter
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class ratings_test extends \advanced_testcase {
+final class ratings_test extends \advanced_testcase {
     /** @var \stdClass test course */
     private $course;
 

tests/readtracking_test.php

@@ -38,7 +38,7 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers \readtracking
  */
-class readtracking_test extends advanced_testcase {
+final class readtracking_test extends advanced_testcase {
 
     /**
      * Test the logic in the moodleoverflow_can_track_moodleoverflows() function.

tests/review_test.php

@@ -40,7 +40,7 @@
  *
  * @group mod_moodleoverflow
  */
-class review_test extends \advanced_testcase {
+final class review_test extends \advanced_testcase {
 
     /** @var \mod_moodleoverflow_generator $generator */
     private $generator;

tests/subscriptions_test.php

@@ -38,7 +38,7 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers \subscriptions
  */
-class subscriptions_test extends advanced_testcase {
+final class subscriptions_test extends advanced_testcase {
 
     /**
      * Test setUp.

tests/userstats_test.php

@@ -39,7 +39,7 @@
  *
  * @covers \userstats_table
  */
-class userstats_test extends \advanced_testcase {
+final class userstats_test extends \advanced_testcase {
 
     /** @var \stdClass test course */
     private $course;