Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionalize the JIT setting #4835

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

bjester
Copy link
Member

@bjester bjester commented Nov 20, 2024

Summary

  • We need to rollback the hotfixes database to v9.6, but the JIT change showed clear benefit, so making this conditional to avoid breaking things still on 9.6

References

#4834

Reviewer guidance

Local

I verified with no observed issues:

  1. Started up devserver
  2. Signed in
  3. Created a new channel

Remote

Verified in python shell that this works:

>>> from django.db.backends.postgresql.features import DatabaseFeatures
>>> f = DatabaseFeatures(connection)
>>> f.is_postgresql_12
True
>>> f.is_postgresql_13
False
>>> f.is_postgresql_11
True

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see it in the documentation, but this property is indeed in the source! https://github.com/django/django/blob/stable/3.2.x/django/db/backends/postgresql/features.py#L91

Looks good to me.

@rtibbles rtibbles merged commit 39fecd2 into learningequality:hotfixes Nov 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants