Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel details modal fixes #4807

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 6, 2024

Summary

Description of the change(s) you made

  • Adds defensive programming checks when author etc. fields aggregate to None rather than a list
  • Checks that a topic has resource descendants before returning more details, as if it has none, the details are mostly useless
  • Updates the check for disabling the publish button to disable it when it has no descendant resources, not just no descendant nodes

Manual verification steps performed

  1. Clicked on the channel details modal for empty channel before publishing, saw no error
  2. Add folders to empty channel, see that publish button is still disabled
  3. Add a resource to empty channel, see that publish button becomes enabled.

References

Fixes #4793

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the Studio: Q4 patch release 1 milestone Nov 6, 2024
@rtibbles rtibbles linked an issue Nov 6, 2024 that may be closed by this pull request
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed no issues

@bjester bjester merged commit 3ef9044 into learningequality:hotfixes Nov 12, 2024
13 checks passed
@rtibbles rtibbles deleted the channel_details_modal branch November 13, 2024 20:29
@pcenov
Copy link
Member

pcenov commented Nov 22, 2024

Tested, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to open channel details for new channel
3 participants