Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi select filters #4718

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Sep 9, 2024

Summary

Description of the change(s) you made

Add checkbox change handler that was missing to handle filter items selection.

Closes #4702

Manual verification steps performed

  1. Selected/unselected items from the dropdowns in content library
  2. Removed items from chips in content library
  3. Removed all items from VAutocomplete and VSelect

Screenshots (if applicable)

Compartir.pantalla.-.2024-09-09.09_19_18.mp4

Does this introduce any tech-debt items?

No


Reviewer guidance

How can a reviewer test these changes?

Play around with the languages filter in the content library tab.

References

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filters are now working correctly. Both code changes and manual QA checkout. Thanks @AlexVelezLl!

@akolson akolson merged commit 8b65d99 into learningequality:unstable Sep 9, 2024
13 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-filter-checkbox branch September 9, 2024 15:46
@pcenov
Copy link
Member

pcenov commented Sep 10, 2024

Hi @AlexVelezLl - noticed just one minor issue: once I've selected a value from the filter when I reopen the same filter the list with items is not displayed in its default state (with the scroll bar up at the top):

filters.default.state.mp4

@AlexVelezLl
Copy link
Member Author

Hi @pcenov! I see, but I suspect that this is not a regression from this PR. Could we have a follow up issue for this, please? :)

@pcenov
Copy link
Member

pcenov commented Sep 10, 2024

Hi @AlexVelezLl - certainly, here it is: #4721

@akolson akolson mentioned this pull request Sep 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Content library - The filters with checkboxes are not working correctly
3 participants