Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump KDS to 4.5.0 #4705

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

nucleogenesis
Copy link
Member

@nucleogenesis nucleogenesis commented Sep 3, 2024

Summary

Description of the change(s) you made

Reviewer guidance

This is for review once merged (as I understand we test this kind of stuff directly on the unstable server?)

Checkboxes

Check that the KDS update does not break checkboxes in general - can select things in Channel editor, clipboard, etc.

Dev Server Smoke test - any issues w/ pinning the volta version this way?

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Thanks @nucleogenesis. (Re-reviewing after spotting build failures..)

package.json Outdated
@@ -130,5 +130,8 @@
"browserslist": [
"> 1%",
"Firefox ESR"
]
],
"volta": {
Copy link
Member

@akolson akolson Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nucleogenesis, Looks like this change is causing a build failure with the error

error Your lockfile needs to be updated, but yarn was run with --frozen-lockfile.

Maybe running yarn install and committing the generated changes in the yarn.lock could solve the issue?

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nucleogenesis, looks like we are having some build failures, please see my comment on added dependency.

@nucleogenesis nucleogenesis changed the title Bump KDS to 4.5.0, add volta key and version in package.json Bump KDS to 4.5.0, ~add volta key and version in package.json~ Sep 9, 2024
@nucleogenesis nucleogenesis changed the title Bump KDS to 4.5.0, ~add volta key and version in package.json~ Bump KDS to 4.5.0 Sep 9, 2024
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @nucleogenesis

@akolson akolson merged commit ea4709b into learningequality:unstable Sep 10, 2024
13 checks passed
@akolson akolson mentioned this pull request Sep 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants