Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate selection text formatting. #4676

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Elide folders from text when 0 folders selected
  • Update all usage of selection text to use common source.
  • Update selection text to appear as text box label to maintain text formatting
  • Flyby fix of string 'What Levels' to 'Edit Levels'

Manual verification steps performed

  1. Selected a single resource
  2. Confirmed that 1 resource is displayed only for the selection text.
  3. Confirmed that no text displays in the quick edit modals.
  4. Select multiple resources or a folder, confirm that appropriate messages display.

Screenshots (if applicable)

Screenshot from 2024-08-23 14-32-20
Screenshot from 2024-08-23 14-32-14
Screenshot from 2024-08-23 14-31-29
Screenshot from 2024-08-23 14-31-21

References

Fixes #4650

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the Studio: Bulk Editing Release milestone Aug 23, 2024
Elide folders when 0.
Update all usage of selection text to use common source.
@rtibbles rtibbles force-pushed the 2_resources_are_better_than_1_double_the_folder_triple_the_fun branch from 1970167 to 143ca8f Compare August 23, 2024 22:00
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. code changes were very clear to follow, and manual QA checks out

@marcellamaki marcellamaki merged commit 57debb9 into learningequality:unstable Aug 27, 2024
13 checks passed
@marcellamaki marcellamaki mentioned this pull request Aug 27, 2024
@radinamatic
Copy link
Member

Manual QA on the unstable branch confirms the fix.

@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Confusing '1 resource selected' text when having selected a folder with resources
3 participants