Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused prod dependencies #4410

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Deletes legacy python script that used to be used to execute minio
  • Removes production dependencies that we seem to no longer use

Manual verification steps performed

  1. Used the fawltydeps package to check for unused dependencies
  2. Did a quick grep of code to make sure they weren't used elsewhere (e.g. gunicorn is referenced in our k8s file, some django plugins/apps are referenced in text only in settings but not with imports)

Reviewer guidance

How can a reviewer test these changes?

Hopefully any issues should show up pretty quickly in tests

Are there any risky areas that deserve extra testing?

References

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Contributor

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@@ -38,5 +35,4 @@ html5lib==1.1
pillow==10.2.0
python-dateutil>=2.8.1
jsonschema>=3.2.0
importlib-metadata==1.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. I added this in this commit, but I didn't specify what I fixed. In the PR, I might elude to something related to it:

Adds jsonschema dependency and resolves cross-dependency versioning conflicts

Whatever those conflicts were, they really don't seem to be a problem now

@bjester bjester merged commit 6ee12dd into learningequality:unstable Jan 26, 2024
11 checks passed
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants