Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Duper Fast Import Search 🚀 #4279

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Sep 12, 2023

Summary

Description of the change(s) you made

This PR makes import from other channel search super fast (reduced query time by almost half) by removing annotations that are no longer needed due to Kolibri public API providing those information.

Manual verification steps performed

Just make sure that import search works.


Reviewer guidance

How can a reviewer test these changes?

Making sure that import search works should make this PR good to go.

References

Closes #4266.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb vkWeb requested a review from bjester September 12, 2023 11:28
@vkWeb
Copy link
Member Author

vkWeb commented Sep 12, 2023

@bjester the failing test has no relation with the code changes here and to double check I ran that test locally and its passing, so this is safe to merge.

@marcellamaki
Copy link
Member

I'll defer approval of the code changes to someone else, but confirming manual QA of import search works as expected

@rtibbles
Copy link
Member

Seemed to just be a flaky test - failure disappeared on rerun.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - I thought as they were excluded from the values call, these annotations wouldn't have any impact - apparently not!

@rtibbles rtibbles merged commit ba592bd into learningequality:hotfixes Sep 13, 2023
@pcenov
Copy link
Member

pcenov commented Sep 18, 2023

Tested and verified at Hotfixes - searching for resources when importing from other channels is functioning correctly.

@vkWeb
Copy link
Member Author

vkWeb commented Sep 18, 2023

Thanks @pcenov! 🚀

@bjester bjester mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants