Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H5p finalization #4255

Merged
merged 3 commits into from
Aug 15, 2023
Merged

H5p finalization #4255

merged 3 commits into from
Aug 15, 2023

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Updates the JS generated le utils for the latest version of le utils
  • Fixes some behaviour observed with some H5P files created in Lumie editor
  • Fixes places referencing the content kind where H5P might otherwise be missing.

Manual verification steps performed

  1. Uploaded various H5Ps, checked that no errors appeared in the console

jredrejo
jredrejo approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes make sense. There's nothing calling my attention.

@rtibbles rtibbles merged commit d76efcf into learningequality:unstable Aug 15, 2023
@rtibbles rtibbles deleted the h5p_finalization branch August 15, 2023 16:20
@marcellamaki marcellamaki mentioned this pull request Aug 31, 2023
Merged
@pcenov
Copy link
Member

pcenov commented Sep 19, 2023

LGTM, no regression issues observed as well!

@bjester bjester mentioned this pull request Sep 27, 2023
Merged
@akolson akolson mentioned this pull request Aug 13, 2024
Merged
@akolson akolson mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jredrejo jredrejo jredrejo approved these changes

@bjester bjester Awaiting requested review from bjester

@nucleogenesis nucleogenesis Awaiting requested review from nucleogenesis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtibbles @pcenov @jredrejo