Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch release v2023.05.10 #4067

Merged
merged 15 commits into from
May 10, 2023
Merged

Patch release v2023.05.10 #4067

merged 15 commits into from
May 10, 2023

Conversation

bjester
Copy link
Member

@bjester bjester commented May 9, 2023 •
edited
Loading

Summary

  • Resolves issue preventing ricecooker chef scripts from uploading audio/video files with presets of the _dependency suffix
  • Resolves issue preventing successful sign-out when a sync is in progress
  • Resolves technical issues related to task enqueuing and management

Details

PR(s) Issues Category QA Focus
#3934 #3931, #3921, #3836 Bug fix Channel editing
#3934 #3925 Bug fix Sign out
#4047, #4041 #4040 Bug fix Upload media files

bjester and others added 15 commits January 27, 2023 08:34
@bjester
[#3931] Fix regression in node diff endpoint, add tests and reorganiz…
216d2de 
…e existing
@bjester
[#3921] Remove signature insurance on task result model
0f39b33
@bjester
[#3836] Retry saving of task model
2bc958b
@bjester
[#3925] Ensure debounce sync returns promise, with some delay for log…
6c29020 
…ging out
@rtibbles
Merge pull request #3934 from bjester/fix-blaines-mistakes
15d1bb6 
Fix production task-related issues and issue logging out
@vkWeb @bjester
Defensive file duration check
012094d
@bjester
Add dependency types to MEDIA_PRESETS
87b522e
@bjester
Temporarily remove check constraint
91cf944
@rtibbles @bjester
Remove deprecated and no longer used codecov library.
9eebeff
@bjester
Skip tests for now
3cc1292
@bjester
Merge pull request #4041 from bjester/duration-constraint-madness
fbb9809 
Temporarily disable file duration check constraint
@bjester
Re-add constraint for file-duration
2f2c28e
@bjester
Revert "Skip tests for now"
5c61836 
This reverts commit 3cc1292.
@vkWeb
Merge pull request #4047 from bjester/readd-constraint-madness
1a9b18c 
Re-add file duration constraint and re-enable tests
@bjester
Merge branch 'master' into hotfixes
ae6a88e
@bjester bjester marked this pull request as ready for review May 9, 2023 17:59
@bjester bjester requested review from rtibbles and radinamatic May 9, 2023 17:59
rtibbles
rtibbles approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look correct to me.

@pcenov
Copy link
Member

pcenov commented May 10, 2023

LGTM @radinamatic @bjester - no issues observed while regression testing.

radinamatic
radinamatic approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passed, good to go! 💯 :shipit:

@bjester bjester merged commit 761a532 into master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

@radinamatic radinamatic radinamatic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjester @pcenov @radinamatic @rtibbles @vkWeb