Update makemessages & transfercontext scripts to use kolibri-tools CLI #4065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
kolibri-tools
relies now on using a CLI to run the commands needed for i18n message extraction and context transfer.This provides commands that ought to properly extract all messages for the frontend and includes an updated command for context transfer.
One thing I wondered is if we should remove the
combineprofiles
script as that doesn't seem to be a part ofkolibri-tools/i18n
any longer.Manual verification steps performed
make i18n-upload --branch=something
and see that the latest messages have been uploaded on Crowdin (or, if you're @bjester test it out on unstable 😄 )make i18n-transfer-context
and it should run, then lint, then things should be updated (assuming more context has been added on Crowdin that isn't currently in the code, anyway).