Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makemessages & transfercontext scripts to use kolibri-tools CLI #4065

Conversation

nucleogenesis
Copy link
Member

Summary

Description of the change(s) you made

kolibri-tools relies now on using a CLI to run the commands needed for i18n message extraction and context transfer.

This provides commands that ought to properly extract all messages for the frontend and includes an updated command for context transfer.

One thing I wondered is if we should remove the combineprofiles script as that doesn't seem to be a part of kolibri-tools/i18n any longer.

Manual verification steps performed

  1. Run make i18n-upload --branch=something and see that the latest messages have been uploaded on Crowdin (or, if you're @bjester test it out on unstable 😄 )
  2. Run make i18n-transfer-context and it should run, then lint, then things should be updated (assuming more context has been added on Crowdin that isn't currently in the code, anyway).

@nucleogenesis nucleogenesis requested review from bjester and rtibbles May 8, 2023 22:39
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With additional changes (for string extraction, which I'll commit later), this has uploaded new strings to Crowdin

@bjester bjester merged commit 6abbbba into learningequality:unstable May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants