Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing staging tree link in UI #4022

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

bjester
Copy link
Member

@bjester bjester commented Apr 12, 2023

Summary

Description of the change(s) you made

  • Updates toolbar to pass along #extension slot content to Vuetify's component to fix missing link to the staging tree
  • Updates logging of sync exceptions to report stack trace, helpful within celery workers
  • Updates yarn run celery to run with --concurrency=1 instead of the default matching the quantity of CPUs available

Screenshots (if applicable)

Screenshot from 2023-04-12 14-54-33


Reviewer guidance

How can a reviewer test these changes?

  1. Have Studio running locally at http://localhost:8080
  2. Use ricecooker to create a cheffed channel:
CONTENTWORKSHOP_URL=http://localhost:8080 python tests/test_chef_integration.py
  1. Open the channel in your local Studio
  2. Verify you see the same as the screenshot

References

Observed in reviewing #3997

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester added changelog Needs to be added to the changelog (remove once added) DEV: backend DEV: frontend TAG: regression labels Apr 12, 2023
@bjester bjester added this to the Studio: next major release milestone Apr 12, 2023
Copy link
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjester sir I ran the manual verification steps and the result matched the screenshot! 🚀 A really useful fix!

This is good to merge, there's just a small curiosity that I've commented.

package.json Show resolved Hide resolved
@ozer550
Copy link
Member

ozer550 commented Apr 13, 2023

I also tested this manually and it's working as expected! great to have the link in UI itself.

Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me as well!

@bjester bjester merged commit 2db72b9 into learningequality:unstable Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Needs to be added to the changelog (remove once added) DEV: backend DEV: frontend TAG: regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants