Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Page Editor Link Fix #3958

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

akash5100
Copy link
Contributor

@akash5100 akash5100 commented Feb 12, 2023

Summary

Description of the change(s) you made

Fixes #3905

  1. Remove this.name from the search Vue component

Manual verification steps performed

Following these steps: #3905 (comment)

Screenshots (if applicable)

Screenshot from 2023-02-12 12-16-33
Screenshot from 2023-02-12 12-16-43

Does this introduce any tech-debt items?


Reviewer guidance

How can a reviewer test these changes?

Following these steps: #3905 (comment)

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb vkWeb requested a review from bjester February 12, 2023 07:12
@vkWeb
Copy link
Member

vkWeb commented Feb 12, 2023

@bjester I've checked this fix. It's working fine locally. You should take a second look and then, it'll be good to go. 😄

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @akash5100 !

@bjester bjester merged commit 5b85ca8 into learningequality:unstable Feb 22, 2023
@akash5100 akash5100 deleted the bug_fix branch February 23, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editors linked to channels on Admin page is yielding a different result
3 participants