Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sentry client errors #3830

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Changes sentry error collection for failed requests to captureException
  • Simplify handling of context and just use the raw error object for simplicity

Manual verification steps performed

  1. Load Studio
  2. In Network tools, turn 'throttling' to Offline
  3. Confirm that the console logging still works for errors
  4. Add raise Exception to the post method of the sync endpoint in endpoint.py
  5. Confirm that the resultant 500 errors are properly logged to the console

@rtibbles rtibbles requested a review from bjester November 22, 2022 00:09
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit 36d6ee2 into learningequality:hotfixes Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants