Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do early return so we don't try to generate a thumbnail when we cannot. #3780

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Do early return so we don't try to generate a thumbnail when we cannot. #3780

merged 1 commit into from
Oct 31, 2022

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • We do a check to see if we have the information we need to generate a thumbnail, but then try to generate the thumbnail anyway
  • This fixes that by returning early

Manual verification steps performed

  1. Upload the epub in the archive here: https://github.com/learningequality/studio/files/9887092/TestGoogleEPUB.zip
  2. Try to generate a thumbnail.
  3. Confirm it tells the user there is an error, but no console errors are shown.

Fixes #3770

@rtibbles rtibbles requested a review from marcellamaki October 28, 2022 16:17
marcellamaki
marcellamaki approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense and manual testing working as expected

@marcellamaki marcellamaki merged commit afa6d24 into learningequality:hotfixes Oct 31, 2022
@rtibbles rtibbles mentioned this pull request Nov 1, 2022
Closed
@pcenov
Copy link
Member

pcenov commented Nov 3, 2022

I confirm, no errors in the console when a thumbnail is not being generated now for that type of EPUBs.

@bjester bjester mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtibbles @pcenov @marcellamaki