Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using the google storage API url in production to prevent CORS issues #3768

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Stop using the google storage API url in production to prevent CORS issues #3768

merged 1 commit into from
Oct 25, 2022

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Uses the /content/storage URL to access files in the frontend

Manual verification steps performed

  1. Ensure that file preview and thumbnail generation still work
  2. Check that the source URL is from the local origin

Screenshots (if applicable)

image

References

Fixes #3764

@rtibbles rtibbles changed the base branch from unstable to hotfixes October 24, 2022 21:38
aronasorman
aronasorman approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@aronasorman aronasorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks about right

@rtibbles rtibbles merged commit 0cb9091 into learningequality:hotfixes Oct 25, 2022
@rtibbles rtibbles deleted the very_cross_about_the_origin branch October 25, 2022 12:58
@rtibbles rtibbles mentioned this pull request Oct 25, 2022
Closed
@pcenov
Copy link
Member

pcenov commented Oct 25, 2022

@rtibbles this has fixed the thumbnail generation issue for all resources except for the EPUB:

2022-10-25_16-52-29

@rtibbles
Copy link
Member Author

Interesting - that looks like a completely different error!

@rtibbles rtibbles mentioned this pull request Oct 25, 2022
Closed
@rtibbles
Copy link
Member Author

Filed a follow up here: #3770

@bjester bjester mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aronasorman aronasorman aronasorman approved these changes

@marcellamaki marcellamaki Awaiting requested review from marcellamaki

Assignees
No one assigned
Labels
TODO: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hotfixes - Thumbnail generation is not working in Firefox and Safari
3 participants
@rtibbles @pcenov @aronasorman