Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow determined by resource to be stored as a value. #3767

Merged

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Updates le-utils and kolibri-constants to 0.1.42 to add determined_by_resource as a valid completion criterion.
  • Uses it to both set and read data to and from the backend
  • Updates tests to confirm that the modal properly sets this.

Manual verification steps performed

  1. Edit an HTML5 app
  2. Set to determined by resource
  3. Ensure that it gets properly set

Screenshots (if applicable)

image

References

Fixes #3750

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pcenov and @radinamatic - I think some of the bugs that you reported will build on this but are not solved by this, (thinking especially of some of the validation errors and display combinations) so just flagging to both of you that I'll be making a PR after this is merged, hopefully tomorrow, and 🤞 that is gets those last completion/duration weirdness settings resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants