Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds regression test for and fixes metadata label syncing. #3712

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Oct 4, 2022

Summary

Description of the change(s) you made

  • Adds support to the sync utility to sync the new metadata labels
  • Adds a regression test to verify the fix

Manual verification steps performed

  1. Wrote regression test.
  2. Fixed behaviour!

References

Noticed in QA by @pcenov here: #3701 (comment)

Contributor's Checklist

Testing:

  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from bjester October 4, 2022 00:22
@bjester
Copy link
Member

bjester commented Oct 5, 2022

@rtibbles @pcenov Referring to the comment on the former PR, is it clear that the option to sync "Titles and Descriptions" results in syncing these metadata attributes? Should we add a followup issue for updating the copy, or should we block this until we are able to do that?

Screenshot from 2022-10-05 10-35-44

@rtibbles
Copy link
Member Author

rtibbles commented Oct 6, 2022

An excellent question - I think given that we've not annotated any public channels with metadata yet, I think we can block this for now and retarget to unstable?

@rtibbles rtibbles changed the base branch from hotfixes to unstable October 27, 2022 16:59
@bjester bjester added this to the Studio: next major release milestone Mar 9, 2023
@rtibbles rtibbles force-pushed the metadata_synchronicity branch from 837b692 to 1dac0df Compare March 15, 2023 00:04
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. followup added to address UI concerns

@bjester bjester merged commit e2e3d68 into learningequality:unstable Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants