Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files existence and length check so validation is run later #3647

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

marcellamaki
Copy link
Member

Summary

Description of the change(s) you made

Adds a simple existence check to files array used in validation.
Fixes #3642

Manual verification steps performed

  1. Open to edit channel details
  2. Set defaults for all options, including the important license field
  3. Upload a PDF or another resource which will automatically default the Learning Activity
  4. Click Finish without interacting with the edit form
  5. Observe that the "error" is no longer present and the file is valid

Screenshots (if applicable)

files-validation.mp4

Does this introduce any tech-debt items?


Reviewer guidance

How can a reviewer test these changes?

  1. Open to edit channel details
  2. Set defaults for all options, including the important license field
  3. Upload a PDF or another resource which will automatically default the Learning Activity
  4. Click Finish without interacting with the edit form
  5. Observe that the "error" is no longer present and the file is valid

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester
Copy link
Member

bjester commented Sep 16, 2022

It seems I can still reproduce the issue, but I don't know why! I watched your recording and I didn't do anything different 🤔
Screenshot from 2022-09-16 12-04-17

@marcellamaki
Copy link
Member Author

Hmmm, okay, thanks @bjester -- I'll take another look! Sorry about that 😕

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue! I can't think of a way to remove the file to trigger the test case so I'm good with this.

@bjester bjester merged commit 98e70e1 into learningequality:unstable Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly uploaded resource shows as incomplete when actually complete
2 participants