Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the file format as the default extension in case the passed in name for the file does not have one. #3646

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Use the file format as the default extension in case the passed in name for the file does not have one. #3646

merged 1 commit into from
Sep 16, 2022

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Fixes small edge case that was showing up for graphie file uploads in ricecooker
  • The graphie files' original filename had no extension, so the files were being uploaded to the checksum with no file extension, and then seemed to have not been uploaded.
  • This uses the supplied file_format as the default extension to prevent this.

@rtibbles rtibbles requested a review from bjester September 16, 2022 00:16
bjester
bjester approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the generate_object_storage_name source, and this looks good to me.

@bjester bjester merged commit 605106a into learningequality:unstable Sep 16, 2022
This was referenced Sep 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjester bjester bjester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @bjester