Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dev dependencies. #3604

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Sep 6, 2022

Summary

Description of the change(s) you made

  • Removes dev dependencies that are not referenced anywhere in the code base, nor used as part of standard dev process (e.g. pre-commit is left in)
  • This does leave in some profiling tools, which are referenced in some of the profiling code. We could in theory split this out in future, but seemed simplest to leave it for now.

Manual verification steps performed

  1. Pip synced the dev requirements
  2. pip install the requirements
  3. ensured that the dev server and services still ran

@rtibbles rtibbles requested a review from bjester September 6, 2022 17:16
Copy link
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean! <3

@bjester bjester merged commit 9f4d367 into learningequality:unstable Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants