Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds translated user friendly string for files with no name #3602

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

akolson
Copy link
Member

@akolson akolson commented Sep 5, 2022

Summary

Description of the change(s) you made

This pr translates the hard coded "file" name for all file uploads with no name, particularly those uploaded via ricecooker. The hard coded "file" remains as is on the backend, but on the frontend it is set to a translated, meaningful string("Unknown filename") to the user.

Manual verification steps performed

  1. Select a Channel>Select a Resource>Edit
  2. Any file with no name should display "file" as its name
  3. If you are unable to find a resource with a file name "file", you may want run the following commands to change all system files to the name '"file". Once done with your checks, you can always rerun the database setup command to reset the database. You might want to use an isolated database for this especially if you already have imported channels you may not want to re-import
  • cd contentcuration
  • ./manage.py shell
  • from contentcuration.models import File
  • File.objects.update(original_filename="file")

Screenshots (if applicable)

Before

Please see #3017

After Fix(en)

Screenshot_2022-09-05_16-32-00

After Fix(ar) - Arabic doesn't exist so defaults to English as shown in console

Screenshot_2022-09-05_16-35-29

Does this introduce any tech-debt items?

No


Reviewer guidance

How can a reviewer test these changes?

Please see Manual verification steps performed above

References

Closes #3017

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson requested review from rtibbles and MisRob and removed request for rtibbles and MisRob September 5, 2022 15:57
@akolson akolson requested review from rtibbles and MisRob September 7, 2022 06:21
@akolson akolson requested a review from bjester September 7, 2022 06:29
@akolson akolson marked this pull request as ready for review September 7, 2022 06:30
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A check for the case of an empty string doesn't look quite right to me. Adding an additional test for that case may help!

Also, if you wanted to go a little further, I think you could consider removing the defaulting of original_filename to file on the backend, where it was mentioned in the issue. Perhaps, just default to an empty string to save space since saving 'file' to the database is somewhat meaningless. That isn't at all necessary to satisfy the issue though, so it's okay if you don't want to change that

@akolson akolson requested a review from bjester September 7, 2022 19:06
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@bjester bjester merged commit a475ed5 into learningequality:unstable Sep 7, 2022
@akolson akolson deleted the string-not-extracted-fix branch October 31, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strings not extracted and/or not translated
2 participants