Ensure channel ID is set on move change to trash tree #3590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
The trash tree root node doesn't have
channel_id
annotated on it, so when deleting resources which moves them to the trash tree, the corresponding change event was missing thechannel_id
since it relied on the destination node having it. This updates that logic to fallback to the source node'schannel_id
, which should only ever be the case for moving to the trash tree.This also adds the channel ID to node creation, since as a side effect, creating a new topic/folder and then immediately trying to delete it would fail given the newly added defensive check that prevents unset
channel_id
on the change objet.Manual verification steps performed
allowed
by the sync endpointReferences
Fixes #3507
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)