Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference selection for duration for audioVideo resources #3583

Merged

Conversation

marcellamaki
Copy link
Member

Summary

Description of the change(s) you made

This PR makes a slight adjustment to how audio and video completion duration is handled.

Per the spec, all four options should be available and selectable in the "duration" dropdown, and the "completion" dropdown should be hidden, with the values set in the background.
Screen Shot 2022-08-25 at 4 28 33 PM

Fixes #3527

Manual verification steps performed

  1. Add a video file
  2. See no completion dropdown
  3. See "duration" dropdown with 4 selectable options
  4. All 4 options, including reference, work

Screenshots (if applicable)

video-reference.mp4

Reviewer guidance

How can a reviewer test these changes?

Please see the testing steps above. This can be done with audio and video files

Are there any risky areas that deserve extra testing?

With manual QA, I went through other file types, and I don't believe I've caused any regressions, but I'm less familiar with the data structure than the front end, and it's possible my understanding missed some things or made assumptions about combinations that can happen that aren't always true, which could potentially result in a combination that doesn't save correctly? (I know from talking to Sairina that there are many permutations here...)

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit e0e5484 into learningequality:unstable Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - The Duration > Reference option is not enabled for .mp3/.mp4 resources
2 participants