Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for and support for copying metadata fields. #3569

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Adds test for copying metadata fields
  • Adds copying behaviour to copy metadata fields

Manual verification steps performed

  1. Add metadata to a node
  2. Copied the node
  3. Verified that the copy had the fields

Screenshots (if applicable)

Original:
Screenshot from 2022-08-22 14-48-19

Copy:
Screenshot from 2022-08-22 14-47-37

Reviewer guidance

How can a reviewer test these changes?

Note: I was unable to replicate either in tests or in the UI the issue of tags not copying.

References

Fixes #3525

@bjester
Copy link
Member

bjester commented Aug 23, 2022

@rtibbles Allan and I tested this and noticed that suggested_duration is still not being copied

@rtibbles
Copy link
Member Author

True! I didn't add that, as it wasn't in the original report, I should have though!

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllanOXDi and I approve!

@bjester bjester merged commit 984ba93 into learningequality:unstable Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Missing values after copying folders and resources
2 participants