Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vuetify-loader. #3487

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 4, 2022

Summary

Description of the change(s) you made

  • Removes vuetify loader
  • Replaces it with explicit imports
  • This seems to prevent memory leaks or at least greatly reduce them
  • It also seems to make the webpack build an order of magnitude faster
  • Updates pre-commit config and frontend linting commands to prevent errors being silently swallowed during precommit.

Manual verification steps performed

  1. Run the devserver
  2. Navigate around the site a bit
  3. Confirm that there are no warnings of unregistered components or directives

@rtibbles rtibbles requested a review from bjester August 4, 2022 23:38
@rtibbles rtibbles force-pushed the vuetify_loader_no_duh! branch from 37a0378 to 5baabca Compare August 5, 2022 00:03
package.json Outdated Show resolved Hide resolved
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement!

@bjester bjester merged commit f730306 into learningequality:unstable Aug 5, 2022
@rtibbles rtibbles deleted the vuetify_loader_no_duh! branch August 22, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants