Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit modal - add completion/duration dropdowns and mastery fields tests #3464

Merged
merged 14 commits into from
Jul 28, 2022

Conversation

sairina
Copy link
Contributor

@sairina sairina commented Jul 22, 2022

Summary

Description of the change(s) you made

Wrote tests for PR #3455

Manual verification steps performed

Ran the tests

Does this introduce any tech-debt items?

Tests run fine, but could use a lot of refactoring!


Reviewer guidance

How can a reviewer test these changes?

Check that the tests successfully run

Are there any risky areas that deserve extra testing?

It's possible I missed a few states in the CompletionOptions component.

References

Fixes #3205


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@sairina sairina requested a review from rtibbles July 22, 2022 18:41
@sairina sairina force-pushed the completion-duration-tests branch from 8340fe8 to 4944024 Compare July 22, 2022 23:06
@sairina sairina force-pushed the completion-duration-tests branch from 4503f67 to 5647998 Compare July 23, 2022 03:46
@rtibbles rtibbles merged commit 8ce233c into learningequality:unstable Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new metadata fields to Edit Modal
2 participants