Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master release for hotfixes completed before 2022-07-07 #3432

Merged
merged 58 commits into from
Jul 11, 2022
Merged

Master release for hotfixes completed before 2022-07-07 #3432

merged 58 commits into from
Jul 11, 2022

Conversation

bjester
Copy link
Member

@bjester bjester commented Jun 27, 2022 •
edited
Loading

Summary

  • Modifies celery configuration to improve and correct task processing issues
  • Adds new content metadata fields to the database, without the capability to edit them through the frontend
  • Adds management commands to backfill metadata
  • Allows admins unlimited file upload storage
  • Refactors storage calculation query to resolve issue with stalling python tests
  • Resolves deployment issues
PR Issues Category QA Focus
#3304 N/A Enhancement/Bug fix Task-based workflows
#3408 #3400, #3401 Enhancement Upload resources
Storage usage
#3434 N/A Enhancement Upload resources
#3444 #3439 Bug fix #3439 steps
#3442, #3449 #3385 Bug fix Copy API Token
#3443 N/A Bug fix N/A
#3435 #3395 Tech debt Task-based workflows
#3402 N/A Tech debt N/A
#3431 N/A Tech debt N/A
#3273 N/A Merge N/A

QA Scenarios

Upload resources

  1. Open an editable channel
  2. Click ADD and select Upload files
  3. Upload a resource that isn't a audio or video
  4. Finalize the details of the resource
  5. Add any additional files like thumbnails or subtitles
  6. Verify everything is saved and functions as expected
  7. Repeat for video and audio resources

Storage usage

Task-based workflows

rtibbles and others added 30 commits August 31, 2021 14:30
@rtibbles
Merge pull request #3273 from learningequality/master
61b7852 
Merge down master to hotfixes
@bjester
Configure task behavior to acknowledge after execution to trigger req…
2e968d4 
…ueuing when interrupted
@bjester
Re-enable gossip and mingle
f382b19
@rtibbles
Merge pull request #3304 from bjester/task-interruption-persistence-h…
584aabd 
…otfixes

[hotfixes] Configure task behavior to acknowledge after execution to trigger requeuing when interrupted
@rtibbles
Don't use git:// protocol for unauthenticated github access.
95657fd
@bjester @rtibbles
Move minio to dev requirements, update urllib3
4b7d721
@bjester @rtibbles
Update dev requirements
99c04d5
@vkWeb @rtibbles
chore: minio 3.0.3 -> 7.1.1
45632d1
@vkWeb @rtibbles
chore: remove ipdb
9b34111
@vkWeb @rtibbles
tests: use the new remove object api & cleanup unused functions
bb6e2d7
@vkWeb @rtibbles
feat: welcome postgres 12!
a47396f
@vkWeb @rtibbles
Pin CI services version to same as docker-compose services
3ce3548
@vkWeb @rtibbles
fix: pin postgres major & use minio/minio on CI
35e2f95
@vkWeb @rtibbles
fix: unnecessary exports removed from minio CI
94478d9
@vkWeb @rtibbles
fix: CI
a963f97
@vkWeb @rtibbles
fix: Blaine's elegant solution!
5b32ef9
@aronasorman @rtibbles
fix: use the jspdf https url instead of git:// (#3349)
66dca07 
* fix: use the jspdf https url instead of git://

git:// started failing recently, and no docker build can happen

* fixup! fix: use the jspdf https url instead of git://

Co-authored-by: Aron Asor <[email protected]>
@rtibbles
Merge pull request #3402 from rtibbles/cherry-pick-hotfixes
268654f 
Deployment relevant cherry picks for hotfixes
@dependabot @rtibbles
Bump pillow from 8.2.0 to 8.3.2
b02d45c 
Bumps [pillow](https://github.com/python-pillow/Pillow) from 8.2.0 to 8.3.2.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst)
- [Commits](python-pillow/Pillow@8.2.0...8.3.2)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @rtibbles
Bump django from 3.2.4 to 3.2.5
5f7775e 
Bumps [django](https://github.com/django/django) from 3.2.4 to 3.2.5.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.4...3.2.5)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@bjester @rtibbles
Update le-utils with release containing new completion criteria schema
76cdf6d
@bjester @rtibbles
Update dependencies
5341ea4
@dependabot @rtibbles
Bump django from 3.2.5 to 3.2.13
8e868d6 
Bumps [django](https://github.com/django/django) from 3.2.5 to 3.2.13.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.5...3.2.13)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@rtibbles
Delete unused Exercise model.
1fa2d28
@rtibbles
Delete unused permissions, tasks, and models.
75486ce
@rtibbles
Add metadata labels to contentnode model.
2ba683a
@rtibbles
Remove unused views.
b051b44
@bjester @rtibbles
Add duration to File model
d962552
@rtibbles
Do a direct lift from unstable to ensure exact migrations.
5d6711a
@rtibbles
Set default learning activity on creation if not already set.
eb07b75
rtibbles added 2 commits June 28, 2022 16:25
@rtibbles
Merge pull request #3435 from bjester/no-late-acknowledgement
062a545 
Rollback late acknowledgement and configure visibility timeout
@rtibbles
Merge pull request #3434 from learningequality/rtibbles-patch-2
e405fc8 
Add admin trap door for space checks.
@bjester bjester changed the title Master release for hotfixes completed before 2022-06-09 Master release for hotfixes completed before 2022-06-29 Jun 29, 2022
@bjester bjester requested a review from radinamatic June 29, 2022 16:28
@bjester bjester marked this pull request as ready for review June 29, 2022 16:28
@bjester bjester requested a review from rtibbles June 29, 2022 16:29
@aronasorman
Merge pull request #3431 from learningequality/rtibbles-patch-1
24b1e1d 
Add makefile target for set_file_duration command
@pcenov
Copy link
Member

pcenov commented Jul 4, 2022

@bjester I ran our collection of critical workflows scenarios and in general everything is functioning correctly.
I found the following missing string issue: #3439
The following known issues are worth mentioning as still valid: #3385, #3386, #3186, #3112
cc @radinamatic

@bjester
Copy link
Member Author

bjester commented Jul 5, 2022

Thanks @pcenov, I added that string issue #3439 to our next release milestone

rtibbles and others added 15 commits July 5, 2022 16:43
@rtibbles
Add stream parsing fallback for duration setting.
0aca5e6
@rtibbles
Exclude dependency presets from listings.
de3acc5
@rtibbles
Add makefile target for set_default_learning_activities
246e655
@bjester
Merge pull request #3444 from rtibbles/all_the_presets_independent
0e83035 
Exclude dependency presets from listings.
@rtibbles
Remove debugging code.
7ca3856
@rtibbles
force file format from extension for ffprobe call.
9dd686d
@bjester
Merge pull request #3443 from rtibbles/duration_set
365f077 
Add stream parsing fallback for duration setting.
@bjester
patch QJoin class to resolve Django 3+ interaction issue
a21065a
@rtibbles
Merge pull request #3449 from bjester/patch-django-cte-qjoin
44efd5d 
Patch django-cte QJoin class to resolve Django 3+ interaction issue
@bjester
Update django cte to resolve API key issue
3a8fc1c
@bjester
Remove runserver
7842852
@bjester
Upgrade django-cte again after upstream fix and release
a11789e
@bjester
Remove django-cte patch
487c052
@rtibbles
Merge pull request #3442 from bjester/update-django-cte
b6a81e0 
Update django-cte to resolve query issue preventing access to API key
@rtibbles
Merge pull request #3445 from learningequality/rtibbles-patch-2
cdbab37 
Add makefile target for set_default_learning_activities
radinamatic
radinamatic approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, ready to roll! 💯 :shipit:

@bjester bjester changed the title Master release for hotfixes completed before 2022-06-29 Master release for hotfixes completed before 2022-07-07 Jul 11, 2022
@bjester bjester merged commit 18dd59e into master Jul 11, 2022
@bjester bjester mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

@radinamatic radinamatic radinamatic approved these changes

Assignees
No one assigned
Labels
TODO: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bjester @pcenov @radinamatic @rtibbles @vkWeb @aronasorman