[DO NOT MERGE, PROOF OF CONCEPT] Studio performance - Remove Vuex file module #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when running services via Docker
rtibbles
reviewed
Jun 28, 2022
There was a problem hiding this comment.
Nothing jumps out at me as obviously flawed in the approach - I do still think that the use of composables does help to clarify use of state, and ensure that it gets cleared when components get cleared also.
Even if this doesn't give us memory improvements, I think it's a code base improvement by pushing towards encapsulated state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be introduced in the meeting together with performance measurements.
Opening a PR so that we can walk through it together and comment on code later if needed.