-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change reading for mastery_model #3362
Change reading for mastery_model #3362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes needed - to confirm you have caught all instances, have you searched for mastery_model
in the Python files?
The other thing that is missing here is a unified representation from the ContentNode viewset, there have been no changes there, so it would currently be up to the frontend to also handle this data being present in either location.
contentcuration/contentcuration/management/commands/mark_incomplete.py
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/management/commands/handling_function.py
Outdated
Show resolved
Hide resolved
Note that this still needs updates in the ContentNode viewset also. |
exercise_data_type = "" | ||
if exercise_data.get('mastery_model'): | ||
exercise_data_type = exercise_data.get('mastery_model') | ||
if exercise_data.get('option') or exercise_data.get('option').get('completion_criteria') or exercise_data.get('option').get('completion_criteria').get('mastery_model'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be and
not or
here, otherwise you are trying to access .get
from None
, if exercise_data.get('option')
is None
.
I think if you fix this, the tests should pass, and we can merge this PR. We'll manage the rest in follow up work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changed
Summary
Description of the change(s) you made
Fixes parts of #3339
I change the reading for mastery model and put both cases for reading.
Comments
I am not sure if I change everywhere the master_model, i search the project but could not find other ones.
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)