Tests and updates for addition/deletion of metadata labels #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdates and remove keys when None.
rtibbles
force-pushed
the
dotpath_deletion
branch
from
b9ca4bc to
428b3a8
Compare
bjester
reviewed
Apr 8, 2022
| else: | ||
| raise ValidationError("Tried to access a dot path in an invalid type") | ||
| # Finally, delete the final key | ||
| obj.pop(key.split(".")[-1]) |
There was a problem hiding this comment.
This is an intense chunk of code. The key splitting, object resolution piece seems like it could be a utility function? Is it something we do elsewhere?
There was a problem hiding this comment.
We have something not dissimilar on the client side, I think we could turn it into a utility function, but wanted to keep it constrained for now until we work out exactly how we'd want it to be generalizable.
bjester
approved these changes
Apr 13, 2022
This was referenced Sep 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Noneto match the expected behaviour from Dexie generated update events.Manual verification steps performed
Ran the new tests!