-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic to folder #3307
Merged
Merged
Topic to folder #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radinamatic
reviewed
Dec 2, 2021
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
radinamatic
reviewed
Dec 2, 2021
contentcuration/contentcuration/frontend/channelEdit/components/move/NewTopicModal.vue
Outdated
Show resolved
Hide resolved
radinamatic
reviewed
Dec 2, 2021
contentcuration/contentcuration/frontend/channelEdit/components/move/NewTopicModal.vue
Outdated
Show resolved
Hide resolved
radinamatic
reviewed
Dec 2, 2021
contentcuration/contentcuration/frontend/channelList/views/Channel/CatalogFAQ.vue
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
radinamatic
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User string changes look good to me, thank you @d0sadata! 👍🏽
bjester
approved these changes
Dec 13, 2021
Closed
This was referenced Sep 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Changed all instances of Topic to Folder that are user facing, by chaging trs objects and createTranslator instances.
Checked and tested everything I could find using the admin account. Changed 1 test to indicate the new changes.
Manual verification steps performed
Does this introduce any tech-debt items?
Whilst changing Topic => Folder is a user facing thing now, we need to change topic to folder on a code level so that there is no future confusion
Comments
Since this is the first major user facing change I have made, this has to be tested properly by someone with more experience with the project.
Contributor's Checklist
PR process:
If this is an important user-facing change, PR or related issue the
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timeIf this includes an internal dependency change, a link to the diff is provided
If any Python requirements have changed, the updated
requirements.txt
files also included in this PROpportunities for using Google Analytics here are noted
Migrations are safe for a large db
Studio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)