Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic to folder #3307

Merged
merged 6 commits into from
Dec 13, 2021
Merged

Topic to folder #3307

merged 6 commits into from
Dec 13, 2021

Conversation

d0sadata
Copy link
Contributor

@d0sadata d0sadata commented Dec 2, 2021

Summary

Description of the change(s) you made

Changed all instances of Topic to Folder that are user facing, by chaging trs objects and createTranslator instances.
Checked and tested everything I could find using the admin account. Changed 1 test to indicate the new changes.

Manual verification steps performed

  1. Went trough the whole applicaiton with an admin account several times to check any place topics might remain.
  2. Ran the test suite multiple time to ensure everything is working properly

Does this introduce any tech-debt items?

Whilst changing Topic => Folder is a user facing thing now, we need to change topic to folder on a code level so that there is no future confusion

Comments

Since this is the first major user facing change I have made, this has to be tested properly by someone with more experience with the project.

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time

  • If this includes an internal dependency change, a link to the diff is provided

  • If any Python requirements have changed, the updated requirements.txt files also included in this PR

  • Opportunities for using Google Analytics here are noted

  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User string changes look good to me, thank you @d0sadata! 👍🏽

@bjester bjester merged commit a21b746 into learningequality:unstable Dec 13, 2021
@d0sadata d0sadata removed their assignment Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants