Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'customContentAnswer' for catalog FAQ #3085

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

radinamatic
Copy link
Member

Summary

Description of the change(s) you made

Updated the 'customContentAnswer' for catalog FAQ.

I figured this was low risk enough even for me to try it out... 😌
cc @bjester since you self-assigned.

Manual verification steps performed

  1. Step 1
  2. Step 2
  3. ...

References

Fixes #3080

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester
Copy link
Member

bjester commented Apr 12, 2021

Thanks @radinamatic! I believe we need this change targeting the catalog branch.

@radinamatic
Copy link
Member Author

Shoot, that was my first thought, but then I saw that the file over there was 11 months old, compared to 4 months on hotfixes 😕

@rtibbles rtibbles changed the base branch from hotfixes to unstable April 19, 2021 19:32
@rtibbles rtibbles merged commit db125b8 into learningequality:unstable Apr 19, 2021
@pcenov
Copy link
Member

pcenov commented Apr 27, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making an update to the Library Catalog FAQ
4 participants