-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flower to dev dependencies #2958
Add flower to dev dependencies #2958
Conversation
f0a9e26
to
07a4cdc
Compare
@@ -39,3 +39,4 @@ pypandoc | |||
git+https://github.com/someshchaturvedi/customizable-django-profiler.git#customizable-django-profiler | |||
tabulate==0.8.2 | |||
fonttools | |||
flower==0.9.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I specified this version because when I didn't do it, I was getting this error during compilation:
Tried: 0.0.1, 0.0.2, 0.0.3, 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.9, 0.0.10, 0.0.11, 0.0.12, 0.0.13, 0.0.14, 0.0.15, 0.0.16, 0.0.17, 0.0.18, 0.0.19, 0.0.20, 0.0.21, 0.1.0, 0.1.1, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 0.4.1, 0.4.2, 0.5.0, 0.6.0, 0.7.0, 0.7.1, 0.8.0, 0.8.0, 0.9.0, 0.9.0
There are incompatible versions in the resolved dependencies:
prometheus-client==0.7.1 (from -c requirements.txt (line 66))
prometheus-client==0.8.0 (from flower==0.9.7->-r requirements-dev.in (line 42))
I didn't want to touch production dependencies in this PR. Flower 0.9.4 is the newest version that worked well with our current dependencies. Is this approach okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely.
|
Codecov Report
@@ Coverage Diff @@
## develop #2958 +/- ##
========================================
Coverage 85.53% 85.53%
========================================
Files 299 299
Lines 15827 15827
========================================
Hits 13538 13538
Misses 2289 2289 Continue to review full report at Codecov.
|
Description
Add Flower to dev dependencies and mention that we have it available in README.
@aronasorman When I run
pip-compile
, it also changed other dependencies' format (maybe it's because I am using the newest version?) Is it okay? To make the review easier, I runpip-compile
on the original requirements-dev.in without adding any new updates and committed the diff. Then I added theflower
package to requirements, recompiled them, and committed this change in another commit.Issue Addressed
I hope this will make locating this tool easier for developers who are not so familiar with backend tooling like me. Also, I noticed that we actually run flower already as part of services command so I assumed that it would work, and it took me a while to figure out that it wasn't working just due to a missing dependency.
Steps to Test
pip install -r requirements-dev.txt
yarn run services