Fixed icon encodings not getting saved #1576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Persists save on channel thumbnail to end of the command
It turns out that Django's save function acts more like a POST request in that all fields get submitted, rather than those that have changed like a PATCH request. This was causing an issue as the
publish_channel
function had one version of the channel and thecreate_content_database
had another version. Thecreate_content_database
method would save the icon_encoding. However, any saving after thecreate_content_database
function would then use the outdated model frompublish_channel
, which caused icon_encoding to get set back to nullThis just passes the model itself to
create_content_database
frompublish_channel
so they are working from the same object in memoryIssue Addressed (if applicable)
Addresses #1299
Steps to Test
Checklist
CHANGELOG
label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time