Vueified channel list page #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into vue-channel-list # Conflicts: # contentcuration/contentcuration/static/js/edit_channel/new_channel/views.js
|
This is a prolific PR! |
Should probably have a shared parent/templating component.
Vue channels list
…into vue-channel-list # Conflicts: # CHANGELOG.md
…t-curation into vue-channel-list
rtibbles
reviewed
Mar 19, 2019
contentcuration/contentcuration/static/js/edit_channel/channel_list/constants.js
Outdated
Show resolved
Hide resolved
| ]), | ||
| { | ||
| channelStrings() { | ||
| return channelStrings; |
There was a problem hiding this comment.
This pattern has cropped up on Kolibri too - seems like it is probably worth my while thinking about how to make $trs work for mixins.
There was a problem hiding this comment.
That would be great!
contentcuration/contentcuration/static/js/edit_channel/channel_list/mixins.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/static/js/edit_channel/channel_list/mixins.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/static/js/edit_channel/channel_list/mixins.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/static/js/edit_channel/channel_list/views/ChannelListPage.vue
Show resolved
Hide resolved
contentcuration/contentcuration/static/js/edit_channel/channel_list/views/ChannelStar.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/static/js/edit_channel/channel_list/vuex/getters.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/static/js/edit_channel/channel_list/vuex/mutations.js
Outdated
Show resolved
Hide resolved
rtibbles
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vueified channel list page
Issue Addressed (if applicable)
#900
#721
#1258
Steps to Test
Implementation Notes (optional)
Does this introduce any tech-debt items?
I have added a
TODO: REMOVE BACKBONEcomment wherever we can remove our dependency on backboneAs for testing, I was unable to check if a modal has properly been opened (we're still using bootstrap modals). Also, I wasn't able to mock jquery requests as it interferes with backbone's models. I added TODOs in each of these locations
Also, it might be worth considering adding a central studioVue instance to avoid a lot of repetitive Vue.use(Vuex) code
Checklist