Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort countries by localized name #1247

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Sort countries by localized name #1247

merged 2 commits into from
Feb 8, 2019

Conversation

kollivier
Copy link
Contributor

@kollivier kollivier commented Feb 8, 2019 •
edited by jayoshih
Loading

Description

Sorts countries by localized names, rather than just presenting them in the order they are in the pycountry.countries list.

Issue Addressed (if applicable)

Addresses #976

Steps to Test

  • Create a new user and check the country list in the registration info page
  • Go to the storage request form in Account settings and check the country list

Checklist

  • Is the code clean and well-commented?
  • Have the changes been added to the CHANGELOG?
  • Are there tests for this change?
  • Are all user-facing strings translated properly (if applicable)?

Reviewers

If you are looking to assign a reviewer, here are some options:

  • Jordan jayoshih (full stack)
  • Aron aronasorman (back end, devops)
  • Micah micahscopes (full stack)
  • Kevin kollivier (back end)
  • Ivan ivanistheone (Ricecooker)
  • Richard rtibbles (full stack, Kolibri)
  • Radina @radinamatic (documentation)

@kollivier kollivier requested a review from jayoshih February 8, 2019 17:40
jayoshih
jayoshih approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@jayoshih jayoshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Probably good to also consider something like this for the language dropdowns on the front end in the future

@jayoshih jayoshih merged commit e96e9c6 into learningequality:develop Feb 8, 2019
@kollivier kollivier deleted the sort_countries branch February 11, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayoshih jayoshih jayoshih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kollivier @jayoshih