Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a versioned copy of the channel database when publishing #4470

Closed
rtibbles opened this issue Mar 7, 2024 · 3 comments · Fixed by #4475
Closed

Generate a versioned copy of the channel database when publishing #4470

rtibbles opened this issue Mar 7, 2024 · 3 comments · Fixed by #4475
Assignees

Comments

@rtibbles
Copy link
Member

rtibbles commented Mar 7, 2024

Desired behavior

Persist old versions of channel databases - in order to not make this onerous, we should do this in a forward looking way.

When a channel is published, continue the current behaviour of putting it in storage under the default name. Also put it into storage under the additional name:

<channel_id>-<channel_version>.sqlite3

This means that the next time the channel is published, we will still have a copy of this channel database.

Current behavior

When a channel is republished, the old channel database is overwritten and lost.

Value add

Prevent data loss, allow for inspecting historic channel versions for trouble shooting, allow for installation of historic channels, easier and repeatable testing of channel upgrade workflows.

Possible tradeoffs

This would add a small additional space requirement for a channel, that would grow over time. We might eventually want to place a limit on the number of historic versions if this became a concern.

@poju3185
Copy link
Contributor

@rtibbles Could you review my PR? Thanks.

@rtibbles
Copy link
Member Author

I have assigned you - and will have a look. Please ask to be assigned for any future issues like you did elsewhere!

@poju3185
Copy link
Contributor

Understood, thank you for letting me know!

rtibbles added a commit that referenced this issue Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants