Flag non-unique value at the whole value level.

Disable editing of anything except the completion dropdown when non-unique.
learningequality · Nov 4, 2022 · 20abd99 · 20abd99
1 parent 0ee2f0e
commit 20abd99
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/edit/CompletionOptions.vue b/contentcuration/contentcuration/frontend/channelEdit/components/edit/CompletionOptions.vue
@@ -5,6 +5,8 @@
     <Checkbox
       v-model="learnerManaged"
       color="primary"
+      :indeterminate="notUnique"
+      :disabled="notUnique"
       :label="$tr('learnersCanMarkComplete')"
       style="padding-bottom: 16px;"
     />
@@ -17,6 +19,7 @@
             ref="completion"
             v-model="completionDropdown"
             box
+            :placeholder="getPlaceholder('value')"
             :items="showCorrectCompletionOptions"
             :label="translateMetadataString('completion')"
             :required="required"
@@ -61,6 +64,7 @@
             ref="duration"
             v-model="durationDropdown"
             box
+            :placeholder="getPlaceholder('value')"
             :items="selectableDurationOptions"
             :label="translateMetadataString('duration')"
             :required="required"
@@ -205,6 +209,9 @@
       },
     },
     computed: {
+      notUnique() {
+        return this.value === nonUniqueValue;
+      },
       model() {
         return this.value.model || defaultCompletionCriteriaModels[this.kind];
       },
@@ -238,6 +245,9 @@
       },
       completionDropdown: {
         get() {
+          if (this.notUnique) {
+            return;
+          }
           if (
             this.value.modality === ContentModalities.QUIZ &&
             this.model === CompletionCriteriaModels.MASTERY

diff --git a/contentcuration/contentcuration/frontend/channelEdit/components/edit/DetailsTabView.vue b/contentcuration/contentcuration/frontend/channelEdit/components/edit/DetailsTabView.vue
@@ -635,10 +635,11 @@
       thumbnailEncoding: generateGetterSetter('thumbnail_encoding'),
       completionAndDuration: {
         get() {
-          const { completion_criteria, modality } = this.getExtraFieldsValueFromNodes(
-            'options',
-            {}
-          );
+          const options = this.getExtraFieldsValueFromNodes('options', {});
+          if (options === nonUniqueValue) {
+            return nonUniqueValue;
+          }
+          const { completion_criteria, modality } = options;
           const suggested_duration_type = this.getExtraFieldsValueFromNodes(
             'suggested_duration_type'
           );