Support creation of page-relative links in ArchiveDownloader, and make it default #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges, and make sure that we add needed resources for iframe / a links being added to the zip.
… modify links just for the root page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, by default
ArchiveDownloaderwill always make links page-relative, no longer requiring us to re-write links from the archive when packaging them into a zip. The old behavior can be restored for now, but this should just be temporary and will not be documented since it's for compatibility with a small number of existing chefs that use the code.Also adds docs for
ArchiveDownloader, and thejirocommand line tool as well.