Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional index to aid store deserialization. #232

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Adds conditional index and adds migration

Reviewer guidance

I tried to write a test, but a few attempts didn't yield anything much - and I assume the bigger test will be whether the index gets used on real world data.

Issues addressed

Fixes #228

@rtibbles rtibbles requested a review from bjester October 18, 2024 23:34
@bjester bjester self-assigned this Oct 22, 2024
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. If it doesn't work, the only thought would be that we should use less than and greater than against the partition field instead of LIKE (but I think postgres might do this internally)

@bjester bjester merged commit 5a1d69e into learningequality:release-v0.8.x Oct 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conditional index on morango store to increase deserialization performance
2 participants