Add optional setting to ignore an existing process on resuming a sync #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Morango stores the process ID on the sync session to prevent accidental resumption of a sync that is still active in another process. On Kolibri, if a sync was started via the UI but then fails, when a user tries to manually resume the sync outside of Kolibri's UI and task processing, the check that ensures the process ID is either the same or inactive can fail because the worker processing tasks is likely still a running and active process.
Summary
ignore_existing_process
keyword arg toresume_sync_session
allowing the bypass of checking the existing process IDTODO
Reviewer guidance
Issues addressed
Fixes #193