Allow uploads of .h5p content file in Studio #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manavagr1108
commented
Jun 6, 2023
•
manavagr1108
commented
- This pr is first step towards completing the parent pr.
- This Pr aims to allow studio to upload .h5p format files and their thumbnails.
- This is simply done through updating the presetlookup json file.
rtibbles
reviewed
Jun 6, 2023
le_utils/resources/presetlookup.json
Outdated
| @@ -254,7 +254,7 @@ | |||
| "h5p_thumbnail": { | |||
| "readable_name": "H5P Thumbnail", | |||
| "multi_language": false, | |||
| "supplementary": true, | |||
| "supplementary": false, | |||
There was a problem hiding this comment.
Don't need to update this value - just the one change you have made above is sufficient!
There was a problem hiding this comment.
Okay cool I will update this
manavagr1108
changed the title
rtibbles
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.