Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for percentage threshold for pages completion criteria #103

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

bjester
Copy link
Member

@bjester bjester commented Mar 21, 2022

Summary

  • Adds support for a percentage between 1-100%, inclusive, for the pages completion criteria
  • Breaks out the mastery criteria into separate schema for reuse

@bjester bjester requested review from rtibbles and sairina March 21, 2022 23:29
Copy link
Contributor

@sairina sairina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that mastery and completion criteria are separated, will there need to be any updates I need to make to imports in Studio's frontend to address that?

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also increment the version in setup.py and rerun the build process, and commit the resulting changes in package.json too? Then we can just tag and release straight away.

@bjester bjester requested a review from rtibbles March 29, 2022 20:11
@bjester bjester merged commit 16fa682 into learningequality:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants